[MOSIP-23551] Added validators for doctype and docCat Fileds in Valid document#1180
Open
balaji-alluru wants to merge 4 commits intomosip:developfrom
Open
[MOSIP-23551] Added validators for doctype and docCat Fileds in Valid document#1180balaji-alluru wants to merge 4 commits intomosip:developfrom
balaji-alluru wants to merge 4 commits intomosip:developfrom
Conversation
…cument entity Signed-off-by: Balaji <74903654+balaji-alluru@users.noreply.github.com>
Signed-off-by: Balaji <74903654+balaji-alluru@users.noreply.github.com>
Signed-off-by: Balaji <74903654+balaji-alluru@users.noreply.github.com>
Signed-off-by: Balaji <74903654+balaji-alluru@users.noreply.github.com>
ase-101
reviewed
Feb 25, 2025
Comment on lines
+5
to
+6
| public static final String INVALID_DOC_CAT_CODE = "DocCategory is Invalid"; | ||
| public static final String INVALID_DOC_TYPE_CODE ="DocType is Invalid"; |
Contributor
There was a problem hiding this comment.
Should this be error message or error code?
ase-101
reviewed
Feb 25, 2025
| return properties; | ||
| } | ||
|
|
||
| @Bean("DocCatCodes") |
Contributor
There was a problem hiding this comment.
Let the bean name start with lowercase
ase-101
reviewed
Feb 25, 2025
| return getDocCatCodes(); | ||
| } | ||
|
|
||
| @Bean("DocTypeCodes") |
Contributor
There was a problem hiding this comment.
Let the bean name start with lowercase
ase-101
reviewed
Feb 25, 2025
| mosip.kernel.config.server.file.storage.uri=https://qa3.mosip.net/config/print/mz/qa3-1.1.5/ | ||
| mosip.admin.identityMappingJson=identity-mapping.json | ||
| mosip.admin.applicant-details.exposed-identity-fields=dob,applicantPhoto | ||
| mosip.admin.doccodes-cleanup.fixed-rate=24 |
Contributor
There was a problem hiding this comment.
Could you add a comment to specify the value unit? and also what codes are cleaned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.